Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation bugs in custom-metrics-stackdriver-adapter README #583

Open
asfaltboy opened this issue Oct 21, 2023 · 3 comments
Open

Documentation bugs in custom-metrics-stackdriver-adapter README #583

asfaltboy opened this issue Oct 21, 2023 · 3 comments
Labels
custom-metrics-stackdriver-adapter Issues for custom-metrics-stackdriver-adapter

Comments

@asfaltboy
Copy link

asfaltboy commented Oct 21, 2023

I'm just starting to follow the Custom Metrics - Stackdriver Adapter installation instructions (got here from the GKE doc on 'Optimize Pod autoscaling based on metrics'), and already noticing a few odd issues with the docs:

  • Recommendation to add scopes is likely irrelevant given the content of this doc - we probably want to update this section, link to this doc about access scopes and perhaps replace the oauth instructions with a mention of configuring IAM for the service account associated with the cluster (we can link to the latter section fo the same doc).

    For context, the document begins with:

    Access scopes are the legacy method of granting permissions for your nodes, and for workloads running on your nodes if the workloads use application default credentials (ADC). Access scopes define the OAuth scopes used in API calls from client libraries or the gcloud CLI.

  • The section on 'Workload identity' is missing words, here's an excerpt:

    If you use Workload Identity in your cluster, additional steps are necessary. In the commands below, use your Project ID as and Google Service Account as .

Given the warning in the root of the repo, are contributions welcome? Also, is it even recommended to follow this guide, or is there a way to install the adapter automatically in GKE?

@PaulRudin
Copy link

... in particular in the section about workload identity. Presumably you need to create the GCP service account - but this isn't made explicit.

@CatherineF-dev
Copy link
Contributor

Given the warning in the root of the repo, are contributions welcome?

Yes, contributions are welcomed @asfaltboy

You can create a PR, and we will help review.

@CatherineF-dev
Copy link
Contributor

/label custom-metrics-stackdriver-adapter

@CatherineF-dev CatherineF-dev added the custom-metrics-stackdriver-adapter Issues for custom-metrics-stackdriver-adapter label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom-metrics-stackdriver-adapter Issues for custom-metrics-stackdriver-adapter
Projects
None yet
Development

No branches or pull requests

3 participants