Remove PHP 7.2 and 7.3 testing

anniefu · anniefu · commit f9ed86259d2d · 2021-11-02T14:14:52.000-07:00
diff --git a/.github/workflows/conformance.yml b/.github/workflows/conformance.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        php-version: [ '7.2', '7.3', '7.4','8.0' ]
+        php-version: [ '7.4','8.0' ]
     name: PHP ${{ matrix.php-version }} Conformance Test
     steps:
     - name: Checkout code
diff --git a/tests/CloudEventSdkCompliantTest.php b/tests/CloudEventSdkCompliantTest.php
@@ -27,13 +27,12 @@
 
 /**
  * @group gcf-framework
- * @group newtest
  */
 class CloudEventSdkCompliantTest extends TestCase
 {
     private CloudEvent $cloudevent;
 
-    function setUp(): void
+    public function setUp(): void
     {
         $this->cloudevent = new CloudEvent(
             '1413058901901494',
@@ -57,7 +56,6 @@ function setUp(): void
 
     public function testJsonSerialize(): void
     {
-
         $wrappedEvent = new CloudEventSdkCompliant($this->cloudevent);
 
         $want = '{

Original file line number	Diff line number	Diff line change
`@@ -27,13 +27,12 @@`
`27`	`27`
`28`	`28`	`/**`
`29`	`29`	`* @group gcf-framework`
`30`		`- * @group newtest`
`31`	`30`	`*/`
`32`	`31`	`class CloudEventSdkCompliantTest extends TestCase`
`33`	`32`	`{`
`34`	`33`	`private CloudEvent $cloudevent;`
`35`	`34`
`36`		`- function setUp(): void`
	`35`	`+ public function setUp(): void`
`37`	`36`	`{`
`38`	`37`	`$this->cloudevent = new CloudEvent(`
`39`	`38`	`'1413058901901494',`
`@@ -57,7 +56,6 @@ function setUp(): void`
`57`	`56`
`58`	`57`	`public function testJsonSerialize(): void`
`59`	`58`	`{`
`60`		`-`
`61`	`59`	`$wrappedEvent = new CloudEventSdkCompliant($this->cloudevent);`
`62`	`60`
`63`	`61`	`$want = '{`