Skip to content

Commit ff7c9b9

Browse files
chore: update integration tests for reliability (#54)
1 parent 0a97f53 commit ff7c9b9

File tree

2 files changed

+30
-8
lines changed

2 files changed

+30
-8
lines changed

tests/integration/test_mysql_sync.py

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,13 @@ def setup_and_teardown():
7070

7171
yield credentials
7272

73-
# cleanup user from database
74-
delete_database_user(sql_instance, mysql_username(test_user), credentials)
75-
# re-add member to IAM group
76-
add_iam_member(iam_groups[0], test_user, credentials)
73+
try:
74+
# cleanup user from database
75+
delete_database_user(sql_instance, mysql_username(test_user), credentials)
76+
# re-add member to IAM group
77+
add_iam_member(iam_groups[0], test_user, credentials)
78+
except Exception:
79+
print("------------------------Cleanup Failed!------------------------")
7780

7881

7982
@pytest.mark.asyncio
@@ -90,6 +93,12 @@ async def test_service_mysql(credentials):
9093
- Verifies test user no longer has group role
9194
"""
9295

96+
# remove database user if they exist
97+
try:
98+
delete_database_user(sql_instance, mysql_username(test_user), credentials)
99+
except Exception:
100+
print("Database user must already have been deleted!")
101+
93102
# create aiohttp client session for async API calls
94103
client_session = ClientSession(headers={"Content-Type": "application/json"})
95104

@@ -101,6 +110,8 @@ async def test_service_mysql(credentials):
101110
# make sure test_user is member of IAM group
102111
try:
103112
add_iam_member(iam_groups[0], test_user, credentials)
113+
# wait 5 seconds, adding IAM member is slow
114+
time.sleep(5)
104115
except Exception:
105116
print("Member must already belong to IAM Group.")
106117

tests/integration/test_postgres_sync.py

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,13 @@ def setup_and_teardown():
7171

7272
yield credentials
7373

74-
# cleanup user from database
75-
delete_database_user(sql_instance, test_user, credentials)
76-
# re-add member to IAM group
77-
add_iam_member(iam_groups[0], test_user, credentials)
74+
try:
75+
# cleanup user from database
76+
delete_database_user(sql_instance, test_user, credentials)
77+
# re-add member to IAM group
78+
add_iam_member(iam_groups[0], test_user, credentials)
79+
except Exception:
80+
print("------------------------Cleanup Failed!------------------------")
7881

7982

8083
@pytest.mark.asyncio
@@ -91,6 +94,12 @@ async def test_service_postgres(credentials):
9194
- Verifies test user no longer has group role
9295
"""
9396

97+
# remove database user if they exist
98+
try:
99+
delete_database_user(sql_instance, test_user, credentials)
100+
except Exception:
101+
print("Database user must already have been deleted!")
102+
94103
# create aiohttp client session for async API calls
95104
client_session = ClientSession(headers={"Content-Type": "application/json"})
96105

@@ -102,6 +111,8 @@ async def test_service_postgres(credentials):
102111
# make sure test_user is member of IAM group
103112
try:
104113
add_iam_member(iam_groups[0], test_user, credentials)
114+
# wait 5 seconds, adding IAM member is slow
115+
time.sleep(5)
105116
except Exception:
106117
print("Member must already belong to IAM Group.")
107118

0 commit comments

Comments
 (0)