Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate blueprints/data-solutions/vertex-mlops to google_workbench_instance #2173

Closed
wiktorn opened this issue Mar 25, 2024 · 3 comments · Fixed by #2632
Closed

Migrate blueprints/data-solutions/vertex-mlops to google_workbench_instance #2173

wiktorn opened this issue Mar 25, 2024 · 3 comments · Fixed by #2632

Comments

@wiktorn
Copy link
Collaborator

wiktorn commented Mar 25, 2024

│ Warning: Deprecated Resource
│ 
│   with module.test.google_notebooks_instance.playground,
│   on [...]/cloud-foundation-fabric/blueprints/data-solutions/vertex-mlops/vertex.tf line 82, in resource "google_notebooks_instance" "playground":
│   82: resource "google_notebooks_instance" "playground" {
│ 
│ `google_notebook_instance` is deprecated and will be removed in a future major release. Use `google_workbench_instance` instead.
│ 
│ (and one more similar warning elsewhere)
@ludoo
Copy link
Collaborator

ludoo commented Aug 21, 2024

@wiktorn shall we

  • keep this open and find someone to work on it?
  • deprecate and remove the blueprint?

I would prefer not to keep this issue open indefinitely, WDYT?

@lcaggio
Copy link
Collaborator

lcaggio commented Aug 21, 2024

The same change need to be done in the Data-playground blueprint.

gioconte did a PR (to be finalized).

gioconte, can you work on fixing the 2 blueprints?

@lcaggio
Copy link
Collaborator

lcaggio commented Sep 24, 2024

@gioconte , any comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants