Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SizeLimitHandlerTest is flaky #310

Open
lachlan-roberts opened this issue Nov 15, 2024 · 2 comments
Open

SizeLimitHandlerTest is flaky #310

lachlan-roberts opened this issue Nov 15, 2024 · 2 comments
Assignees
@lachlan-roberts

Comments

@lachlan-roberts
Copy link
Collaborator

seen here https://github.com/GoogleCloudPlatform/appengine-java-standard/actions/runs/11845075033/job/33013808086?pr=304

[stderr] INFO: Stopped timer for request 0000000000000001 0.121 CPU / 0.122 wallclock (99.2%), 203.963 [email protected][0.083 hotspot, 0.000 GC]
Error:  Failures: 
Error:    SizeLimitHandlerTest.testResponseContentAboveMaxLengthGzip:205
Error:    SizeLimitHandlerTest.testResponseContentAboveMaxLength:146 
Expected: <500>
     but: was <200>
Error:    SizeLimitHandlerTest.testResponseContentAboveMaxLength:144
Error:  Errors: 
Error:    SizeLimitHandlerTest.testResponseContentAboveMaxLengthGzip:199 » Timeout
@lachlan-roberts lachlan-roberts self-assigned this Nov 15, 2024
@lachlan-roberts lachlan-roberts mentioned this issue Nov 15, 2024
Merged
@ludoch
Copy link
Collaborator

ludoch commented Nov 20, 2024

We have similar files runtime/test/src/test/java/com/google/apphosting/runtime/jetty9/SizeLimitHandlerTest.java
and runtime/test/src/test/java/com/google/apphosting/runtime/jetty9/SizeLimitIgnoreTest.java

and only the first one seems flaky. Can you study the diffs there? @lachlan-roberts

@lachlan-roberts lachlan-roberts mentioned this issue Nov 26, 2024
Closed
@lachlan-roberts
Copy link
Collaborator Author

it seems SizeLimitIgnoreTest has just been copied from SizeLimitHandlerTest with 2 extra tests. I opened #313 to reduce the duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ludoch @lachlan-roberts