From 7d1079308b3e79eec69bc654eb67fc54711ca9ad Mon Sep 17 00:00:00 2001 From: k-yomo Date: Sat, 28 Oct 2023 23:48:21 +0900 Subject: [PATCH 1/2] Add optional to inputTableSpec in BQ ready options --- .../google/cloud/teleport/v2/transforms/BigQueryConverters.java | 1 + 1 file changed, 1 insertion(+) diff --git a/v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java b/v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java index dd2228f692..16dcf44058 100644 --- a/v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java +++ b/v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java @@ -164,6 +164,7 @@ public static String tableRowToJson(TableRow row) { public interface BigQueryReadOptions extends PipelineOptions { @TemplateParameter.BigQueryTable( order = 1, + optional = true, description = "BigQuery source table", helpText = "BigQuery source table spec.", example = "bigquery-project:dataset.input_table") From 18d0965212fbcbf872139a39687368a0b7047b4a Mon Sep 17 00:00:00 2001 From: k-yomo Date: Sat, 28 Oct 2023 23:49:30 +0900 Subject: [PATCH 2/2] Fix queryLocation option order --- .../cloud/teleport/v2/transforms/BigQueryConverters.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java b/v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java index 16dcf44058..a00e3e66a4 100644 --- a/v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java +++ b/v2/common/src/main/java/com/google/cloud/teleport/v2/transforms/BigQueryConverters.java @@ -207,10 +207,10 @@ public interface BigQueryReadOptions extends PipelineOptions { void setUseLegacySql(Boolean useLegacySql); @TemplateParameter.Text( - order = 4, + order = 5, optional = true, regexes = {"[a-zA-Z0-9-]+"}, - description = "BigQuery geographic location where the query job will be executed.", + description = "BigQuery geographic location where the query job will be executed.", helpText = "Needed when reading from an authorized view without underlying table's permission.", example = "US")