Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give the IndexedDB database a more descriptive name that shows where it came from #23

Open
gae123 opened this issue Oct 25, 2020 · 1 comment
Open

Give the IndexedDB database a more descriptive name that shows where it came from #23

gae123 opened this issue Oct 25, 2020 · 1 comment

Comments

@gae123
Copy link

gae123 commented Oct 25, 2020 •
edited
Loading

The framework uses an IndexDB browser database to store some metadata it needs. It currently names this database keyval-store. When I first run into this database in the browser developer tools I was wondering where it came from.

We should give it a name that shows where it came from.

Contrast the sw-appcache name with the firebase one:

image
@gae123 gae123 changed the title Give the Indexed Give the IndexedDB database a more descriptive name that shows where it came from Oct 25, 2020
@jeffposnick
Copy link
Contributor

My inclination is to leave it as-is for now, as updating it will be a breaking change.

I'm going to leave this issue open, though, and the next time we need to make a breaking change for any other reason, we can piggy-back on that and include this change as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffposnick @gae123