Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browsingContext.traverseCommand does not emit navigation events anymore #2894

Open
1 task
OrKoN opened this issue Dec 13, 2024 · 1 comment
Open
1 task

browsingContext.traverseCommand does not emit navigation events anymore #2894

OrKoN opened this issue Dec 13, 2024 · 1 comment

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Dec 13, 2024

With #2796, navigationInitiatedByCommand is used to decide if events have to be sent. This flag is not set for traverseHistory resulting in unexpected behavior.

The Puppeteer test "[navigation.spec] navigation Page.goBack should work" is the scenario that does not work any longer. cc @sadym-chromium

  • we need WPT test coverage for events by traverse history
@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 13, 2024

cc @sadym-chromium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OrKoN