Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wasm files by default in globPatterns #3319

Open
ArhanChaudhary opened this issue Apr 27, 2024 · 0 comments
Open

Support wasm files by default in globPatterns #3319

ArhanChaudhary opened this issue Apr 27, 2024 · 0 comments

Comments

@ArhanChaudhary
Copy link
Contributor

The default value of globPatterns is ["**/*.{js,css,html}"]

I think it would be perfectly reasonable to also serve wasm files through workbox by changing this default to ["**/*.{js,wasm,css,html}"]

Javascript and wasm are supposed to be used together. Having Javascript served through workbox while wasm through the network can result in a confusing version mismatch, footgunning future devlopment.

I originally came from this issue raised by another developer who shared a similar sentiment vite-pwa/vite-plugin-pwa#308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant