Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Visually Complete 100% to group: 'metrics' #5741

Closed
denar90 opened this issue Jul 27, 2018 · 2 comments
Closed

Add Visually Complete 100% to group: 'metrics' #5741

denar90 opened this issue Jul 27, 2018 · 2 comments
Labels
needs-priority

Comments

@denar90
Copy link
Contributor

denar90 commented Jul 27, 2018

Hi,
Does it make sense to add Visually Complete 100% to metrics group, it is for pwmetrics? It's kinda "delightful" indicator for loading perf. It's already present in metricsDefinitions() but used for assets savings.

cc @paulirish @patrickhulce
@paulirish
Copy link
Member

not adding an audit for it.

the observed value in is the 'metrics' audit as observedLastVisualChange

@denar90
Copy link
Contributor Author

denar90 commented Aug 27, 2018

Thx Paul, further discussion could be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulirish @brendankenny @denar90