Donation with the same QR won't appear in project donation list

[maryjaf]

The users be able to donate to a project twice with one QR code
In this situation one of these donations is shown in project donations and user donations list

for example these two transaction was made by a QR code and the one of them is shown in project donation table

Transaction ad504d24e7b83b0e22f152b4643361756dcbbee1c4aac0371137b806bf6e6c46

Transaction d02a1bf00da3ffcc344d4700ff2dfadfe3d28bd981a8765565a8fcf27babd305 (it is shown in list of project donation)

cc: @MoeNick

[maryjaf]

#4591 (comment)

[Meriem-BM]

Implementation: After a transaction is detected by the cron job, an additional check is triggered 2 seconds later. This second check searches for any similar transactions that match specific criteria: the same source address, destination address, amount, and (if provided) memo, with a timestamp within 1 minute of the initial transaction. If such a matching transaction is found, a new donation is created.

cc: @maryjaf

[maryjaf]

I think this implementation makes some problem
consider this scenario:

• I tap on donate with a sign user (maryam )on chrome
• the amount is 0.01
• I complete donation flow and it is success
• At the same time I make another donation with not signed user on firefox with same amount
• I complete this donation flow also
• in this case I see two record in donation table for maryam user and my donation in firefox is still shown pending

@Meriem-BM

[maryjaf]

• in this case I see two record in donation table for maryam user and my donation in firefox is still shown pending

Two donations are recorded in donation tabel but the user for both of them are shown maryam, but my donation on firefox was with not signed user

[maryjaf]

https://staging.giveth.io/project/test-stellar?tab=donations

https://stellar.expert/explorer/public/tx/7e176a3236e3fe867e8a78748ec9ae3975d0cdc5e0d84f0f36c7640fbb3e4356
https://stellar.expert/explorer/public/tx/67b7287c1654cbb511deb1cd25670f0b9f4b18dfc7521759774fe28b4652286b

[Meriem-BM]

Got it, this happened because of using same wallet.

[maryjaf]

Got it, this happened because of using same wallet.

So another condition should be added to prevent this behavior ?

[divine-comedian]

still have some edge cases that needs to find a way - 2 donations with same QR we can add them both, still needs to figure out solution

[divine-comedian]

@Meriem-BM still needs to do research on this