-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to delete draft projects #1271
Comments
omg guys this is getting painful... @divine-comedian @mosaeedi there was an update to "My projects" where now the projects info takes up so much more space on the page... and I still can't delete all the useless drafts which all appear FIRST. above my very legitimate projects.. Giveth & the matching pool. so "my projects" is just now a total mess for me, and I'm sure I'm not the only one.. can we please prioritize this issue? delete.draft.mov |
This looks great! I made Giveth/impact-graph#1519 to follow up making the back-end endpoint for this before proceeding with FE |
you guys are amazing <3 thank you |
@mohammadranjbarz Do we have an API to delete draft projects? |
No we don't have any API for deleting projects (draft or non-draft) |
@mohammadranjbarz - issue was made here about 2 months ago, but it was never assigned to anyone 😅 |
|
@mohammadranjbarz Is there any new update for it? |
I just assigned it to @Reshzera , he will let you know here when implemented and merged |
@MohammadPCh - @Reshzera has implemented the BE endpoint, Is there another FE dev we can pass this to? @Reshzera please share any details on accessing the endpoint |
the backend has been merged in https://github.com/orgs/Giveth/projects/9/views/1?filterQuery=+status%3Adone+is%3Aopen+-label%3AStellar&pane=issue&itemId=68913749 Since Rafael is no longer here we will need to find the endpoint and how to integrate it in the FE to allow draft projects to be deleted. @kkatusic pick this one up whenever you have time. |
@divine-comedian, I will take it, thx |
@laurenluz, cc @divine-comedian, we have problem with environment variable, after investigation @mhmdksh fixed. You can try to check change on staging domain. |
Test Update When project status is "Draft", the "Delete Project" option is present - Pass When Project status is "Active" the "Delete Project" option is absent - Pass Functional issue However, I am unable to complete the delete process, as no action is taken after clicking on the "Delete Project" button Latifat.Abdullahi._.Giveth.-.Google.Chrome.2024-09-05.17-20-57.mp4UI issue From the design above, the "Project name" should be bold as well. |
@LatifatAbdullahi this function for delete is missing from code I'm investigating :) |
hey guys, this issue is on prod, but it's not working, see recording... Screen.Recording.2024-09-24.at.7.13.42.PM.mov |
@kkatusic @LatifatAbdullahi I'm not sure this feature passed QA - so how did it end up in production? |
Last time this was tested, the delete action failed and it was still being investigated, that's why its still open. |
OK but the code - which doesn't work - has been pushed to production, so now this is a problem that we have to focus on fixing and push a hotfix.. |
no code pushed, just environment variable: |
@laurenluz, cc @divine-comedian, when you get time can you please check on production side is that option removed? thx |
Thanks @kkatusic so we'll continue work on staging for the remaining bugs that @LatifatAbdullahi reported above |
If you are busy with unicorn tasks , I can take this issue @LatifatAbdullahi |
Now the "delete" option is only shown in my project list, shouldn't this option also be shown in project page ? like as continu creation button a button there should be for delete? |
I have so many sketchy test drafts in "my projects" with no clear way to get rid of them? Can we add a little trashcan w/ an "are you sure?" modal please?
@mosaeedi @MoeNick
The text was updated successfully, but these errors were encountered: