Skip to content

Commit 770608c

Browse files
committed
Revise find_git_associated_windows_executable future directions
It didn't mention how expanded use may require directories like `mingw64/bin` to be added to searched locations, and also was somewhat hard to read. This adds that and rephrases.
1 parent 2efd5b5 commit 770608c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

gix-path/src/env/auxiliary.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,10 @@ const BIN_DIR_FRAGMENTS: &[&str] = &["bin", "usr/bin"];
7171
/// does, which is the case unless it is overridden by setting `GIT_EXEC_PATH` to an unusual value.
7272
///
7373
/// This is currently only used (and only exercised in tests) for finding `sh.exe`. It may be used
74-
/// to find other executables in the future, but may require adjustment. (In particular, depending
75-
/// on the desired semantics, it should possibly also check inside a `cmd` directory, possibly also
76-
/// check inside `super::core_dir()` itself, and could safely check the latter location even if its
77-
/// value is not suitable to use in inferring any other paths.)
74+
/// to find other executables in the future, but may require adjustment. In particular, depending
75+
/// on the desired semantics, it should possibly also check inside a `cmd` directory; directories
76+
/// like `<platform>/bin`, for any applicable variants (such as `mingw64`); and `super::core_dir()`
77+
/// itself, which it could safely check even if its value is not safe for inferring other paths.
7878
fn find_git_associated_windows_executable(stem: &str) -> Option<OsString> {
7979
let git_root = git_for_windows_root()?;
8080

0 commit comments

Comments
 (0)