Replies: 1 comment 2 replies
-
Filtering on file path sounds like a reasonable addition to the filtering capabilities. PRs are welcome. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
CommitsSinceVersionSource is fine as-is, but I'd prefer BuildMetaData to reflect the number of commits or pushes that affected the compiled assemblies. This would require additional configuration on the users' end to set up and would default to the current behavior.
This could be done automatically for some projects by comparing a list of changed files to the list of files in the Microsoft .*proj files. Then, if the former lacks all files from the latter, skip GitVersion operation. Additional configuration may be necessary for edge cases that use pre-build or post-build scripts to affect the build artifacts.
Example A
If a CI build is cancelled or skipped, but didn't explicitly fail, the next successful build should reuse the version info.
Example B
In the previous example, the build may have been automatically cancelled by a script or set of rules that determine if the build artifacts would be significantly different from the previous build. I use something like that to determine if a GitHub Release should be created or not. My use-case determines it based on if the Push does not include changes to
./src/
, including/excluding paths e.g. include gitmodule build dependency, exclude nested ReadMe files.Beta Was this translation helpful? Give feedback.
All reactions