Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Try again for “Cannot load file type” does not work #2493

Closed
Huddie opened this issue Nov 27, 2018 · 6 comments
Closed

Try again for “Cannot load file type” does not work #2493

Huddie opened this issue Nov 27, 2018 · 6 comments
Labels
🐛 bug Unintended behaviour within the app ✨ good first issue An issue suitable for someone looking to get familiar with the codebase

Comments

@Huddie
Copy link
Collaborator

Huddie commented Nov 27, 2018

Thoughts:

  1. Hook up try again to make it work
  2. Remove try again (if we cannot load it the first time, we cannot load it the second time).
Bug Report Dump (Auto-generated)
Version 1.25.0 (1542806489)
Device: iPhone XR (iOS 12.1)
TestFlight: false
@Huddie Huddie added the 🐛 bug Unintended behaviour within the app label Nov 27, 2018
@rnystrom
Copy link
Member

Does it actually not do anything, or does it just fail to load again? Does FLEX show new network requests?

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 27, 2018

@rnystrom I’ll check. It didn’t show the spinner which is usually the first thing that happens when the try again is pushed

Sent with GitHawk

@rnystrom
Copy link
Member

It may just load too fast, but also may not be wired up 🤷‍♀️

Either way retrying will just error and show the same screen again. More important for situations where the screen actually fails to load

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 27, 2018

@rnystrom I tried with FLEX. No network requests expect the initial attempt.
This isn’t a big deal but I feel like if we have a button it should do something. Even though i suspect it will produce the same result

Sent with GitHawk

@rnystrom
Copy link
Member

rnystrom commented Nov 27, 2018

Ya this is def a bug then. Would stink to actually fail a network request then be stuck.

@Huddie feel free to nab

Sent with GitHawk

@rnystrom rnystrom added the ✨ good first issue An issue suitable for someone looking to get familiar with the codebase label Nov 27, 2018
@Huddie
Copy link
Collaborator Author

Huddie commented Nov 27, 2018

@rnystrom I'll take this after finishing the Github V4 mutation stuff for #2482. Just in case someone wants to pick this up in the meantime.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Unintended behaviour within the app ✨ good first issue An issue suitable for someone looking to get familiar with the codebase
Projects
None yet
Development

No branches or pull requests

2 participants