Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize link picker #22

Open
bjarnef opened this issue Oct 30, 2017 · 0 comments
Open

Localize link picker #22

bjarnef opened this issue Oct 30, 2017 · 0 comments

Comments

@bjarnef
Copy link

bjarnef commented Oct 30, 2017 •
edited
Loading

It seems the text "Choose" is not localized.

Umbraco-Link-Picker/src/App_Plugins/GibeLinkPicker/picker.html

Line 10 in 1bdaa7e

<a class="link" href="" ng-click="chooseLink()">Choose</a>

You should be able to use the general_choose key in Umbraco core.
https://github.com/umbraco/Umbraco-CMS/blob/b04d71ca5f816b88fac64c82efa26c663896d699/src/Umbraco.Web.UI/umbraco/config/lang/en.xml#L524

<localize key="general_choose">Choose</localize>

I also noticed a few other issues (Umbraco 7.6.11) and latest version of Link Picker

image

Umbraco-Link-Picker/src/App_Plugins/GibeLinkPicker/Dialogs/linkpicker.html

Line 73 in 1bdaa7e

<a href ng-click="switchToMediaPicker()" class="btn">Link to file</a>

Instead of "Link to file" you can use either defaultdialogs_selectMedia or defaultdialogs_linkToMedia key.

https://github.com/umbraco/Umbraco-CMS/blob/ef0d6eff2ce4ab0bcdfb806b514fcceb2df6f01e/src/Umbraco.Web.UI.Client/src/views/common/overlays/linkpicker/linkpicker.html#L73-L80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjarnef