Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CallKit]Custom ringtone support #628

Merged
merged 3 commits into from
Jan 3, 2025
Merged

[CallKit]Custom ringtone support #628

merged 3 commits into from
Jan 3, 2025

Conversation

ipavlidakis
Copy link
Collaborator

🎯 Goal

Allow custom ringtones for CallKit ringing calls.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Jan 2, 2025
@ipavlidakis ipavlidakis self-assigned this Jan 2, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner January 2, 2025 16:43
martinmitrevski
martinmitrevski reviewed Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use outgoingCallSound in Sounds? Or maybe introduce a new property there?

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 2, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.05 MB 7.05 MB 0 KB 🟢
StreamVideoSwiftUI 2.07 MB 2.07 MB 0 KB 🟢
StreamVideoUIKit 2.21 MB 2.21 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
122 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ipavlidakis ipavlidakis merged commit 2c52184 into develop Jan 3, 2025
13 of 14 checks passed
@ipavlidakis ipavlidakis deleted the feature/callkit-custom-ringtone branch January 3, 2025 08:51
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski