Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Replace #file to #fileID #626

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Dec 16, 2024

🎯 Goal

By reducing logs size we attempt to reduce the SDK size.

📝 Summary

#file in Swift 5 embeds #filePath while in Swift 6 it embeds #fileID. From Apple's documentation for #filePath we get this:

Because #fileID doesn’t embed the full path to the source file, unlike #filePath, it gives you better privacy and reduces the size of the compiled binary. Avoid using #filePath outside of tests, build scripts, or other code that doesn’t become part of the shipping program.

Other users also report same behaviour here

🛠 Implementation

Update all references in Source, to #fileID

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Dec 16, 2024
@ipavlidakis ipavlidakis self-assigned this Dec 16, 2024
Copy link

1 Message
📖 Skipping Danger since the Pull Request is classed as Draft/Work In Progress

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamVideo 7.07 MB 7.05 MB -16 KB 🚀
StreamVideoSwiftUI 2.07 MB 2.07 MB 0 KB 🟢
StreamVideoUIKit 2.21 MB 2.21 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

@ipavlidakis ipavlidakis marked this pull request as ready for review December 16, 2024 14:04
@ipavlidakis ipavlidakis requested a review from a team as a code owner December 16, 2024 14:04
@ipavlidakis ipavlidakis merged commit 9de0d3a into develop Dec 16, 2024
14 checks passed
@ipavlidakis ipavlidakis deleted the fix/update-usaget-to-fileId-rather-file branch December 16, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants