Skip to content

Commit cb2e051

Browse files
fix: feed bloc query and add activities (#207)
Co-authored-by: Sacha Arbonel <[email protected]>
1 parent dd139b0 commit cb2e051

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

packages/stream_feed_flutter_core/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## 0.7.0+1 28/02/2022
2+
3+
- fixes(FeedBloc):
4+
- bug when adding to a fix lengthed list
5+
- change the init behavior of queryEnrichedActivities (to allow it to be called again)
6+
17
## 0.7.0 25/02/2022
28

39
- fix: `FeedProvider` inherited widget had an issue with the `updateShouldNotify` being triggered everytime. This has been fixed via the llc, being bumped to 0.5.1.

packages/stream_feed_flutter_core/lib/src/bloc/feed_bloc.dart

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ class GenericFeedBloc<A, Ob, T, Or> extends Equatable {
140140
final enrichedActivity = await flatFeed
141141
.getEnrichedActivityDetail<A, Ob, T, Or>(addedActivity.id!);
142142

143-
final _activities = getActivities(feedGroup) ?? [];
143+
final _activities = (getActivities(feedGroup) ?? []).toList();
144144

145145
// ignore: cascade_invocations
146146
_activities.insert(0, enrichedActivity);
@@ -435,13 +435,13 @@ class GenericFeedBloc<A, Ob, T, Or> extends Equatable {
435435

436436
//TODO: no way to parameterized marker?
437437
}) async {
438-
activitiesManager.init(feedGroup);
439-
if (_queryActivitiesLoadingController.value == true) return;
440-
441-
if (activitiesManager.hasValue(feedGroup)) {
442-
_queryActivitiesLoadingController.add(true);
438+
if (_queryActivitiesLoadingController.value == true) {
439+
return; // already loading
443440
}
444-
441+
if (!activitiesManager.hasValue(feedGroup)) {
442+
activitiesManager.init(feedGroup);
443+
}
444+
_queryActivitiesLoadingController.add(true);
445445
try {
446446
final activitiesResponse = await client
447447
.flatFeed(feedGroup, userId)
@@ -453,7 +453,6 @@ class GenericFeedBloc<A, Ob, T, Or> extends Equatable {
453453
flags: flags,
454454
ranking: ranking,
455455
);
456-
457456
activitiesManager.add(feedGroup, activitiesResponse);
458457
if (activitiesManager.hasValue(feedGroup) &&
459458
_queryActivitiesLoadingController.value) {

packages/stream_feed_flutter_core/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: stream_feed_flutter_core
22
description: Stream Feed official Flutter SDK Core. Build your own feed experience using Dart and Flutter.
3-
version: 0.7.0
3+
version: 0.7.0+1
44
repository: https://github.com/GetStream/stream-feed-flutter
55
issue_tracker: https://github.com/GetStream/stream-feed-flutter/issues
66
homepage: https://getstream.io/

0 commit comments

Comments
 (0)