Added possiblity to customize no content icons #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
|
Interesting that many other snapshots were also updated by the snapshot job. Everything seems to be in order. While we are updating no content views, should we add snapshot tests for dark mode as well for these views (I guess dynamic type is fine). |
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
https://linear.app/stream/issue/IOS-691/allow-possibility-to-replace-the-messages-icon-in-pinned-messages-view
🎯 Goal
Add possibility to customize icons for "no content" views.
🛠 Implementation
Extracted the images in the
Imagesstruct.🧪 Testing
Describe the steps how this change can be tested (or why it can't be tested).
🎨 Changes
Add relevant screenshots or videos showcasing the changes.
☑️ Checklist