Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS 18 fixes for the swipeable channel list item #601

Merged
merged 6 commits into from
Sep 11, 2024
Merged

iOS 18 fixes for the swipeable channel list item #601

merged 6 commits into from
Sep 11, 2024

Conversation

martinmitrevski
Copy link
Contributor

🔗 Issue Link

Jira or Github issue link, if applicable.

🎯 Goal

Describe why we are making this change.

🛠 Implementation

Provide a description of the implementation.

🧪 Testing

Describe the steps how this change can be tested (or why it can't be tested).

🎨 Changes

Add relevant screenshots or videos showcasing the changes.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@martinmitrevski martinmitrevski requested a review from a team as a code owner September 11, 2024 09:14
@github-actions GitHub Actions
Copy link

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 11, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.06 MB 7.06 MB 0 KB 🟢

laevandus
laevandus approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we would not need that #DEBUG check for Xcode 16 but seems like there is not any other good ways for now.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
88 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@martinmitrevski martinmitrevski merged commit 9a0e85c into develop Sep 11, 2024
11 checks passed
@martinmitrevski martinmitrevski deleted the ios-18-bugfix branch September 11, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laevandus laevandus laevandus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinmitrevski @Stream-SDK-Bot @laevandus