Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen "useNativeDriver" error when viewing an image attachment #302

Closed
amardeepranu opened this issue Aug 26, 2020 · 8 comments
Closed
Assignees

Comments

@amardeepranu
Copy link

amardeepranu commented Aug 26, 2020

On the latest version the react-native-image-zoom-viewer always throws a warning to set useNativeDriver. This can be fixed by updating the library to 3.0.1: ascoders/react-native-image-viewer#398

Simulator Screen Shot - iPhone 11 Pro - 2020-08-26 at 10 18 42

gz#5571

@shodgetts
Copy link

Agent comment from Stephen Hodgetts in Zendesk ticket #5571:

thanks for the report

@DanC5
Copy link
Contributor

DanC5 commented Aug 26, 2020

I see the latest version of react-native-image-zoom-viewer has added useNativeDriver to all the animated timings, upgrading in our library now!

@thegitparticle
Copy link

@DanC5 when can we expect the update for this? Or meanwhile is there any way to fix it for now?

@DanC5
Copy link
Contributor

DanC5 commented Aug 26, 2020

@DanC5 when can we expect the update for this? Or meanwhile is there any way to fix it for now?

The upgrade has already been merged to master, so as soon as @vishalnarkhede makes a new release it'll be out in the wild.

@thegitparticle
Copy link

@DanC5 Also, the actionsheets keep throwing the same error. Is the package which manages them also add the native drive support and has been updated by you?

@DanC5
Copy link
Contributor

DanC5 commented Aug 31, 2020

@DanC5 Also, the actionsheets keep throwing the same error. Is the package which manages them also add the native drive support and has been updated by you?

I just looked into this and the action sheet package we're using, react-native-actionsheet, doesn't specify the native driver in their animated timings. Revamping the action sheet is something that's on our to-do list though, so thanks for another ping on this.

@sclavijo93
Copy link

Hi, any news about this? 😅

@DanC5
Copy link
Contributor

DanC5 commented Sep 29, 2020

Hi, any news about this? 😅

Hey Saul, while we haven't removed this package yet, we have allowed the ability to customize the action sheet component. If you use the ActionSheet prop on the MessageSimple component, you can create your own action sheet and override the default behavior which calls the react-native-actionsheet dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants