Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: SupabaseAdapter is missing the onConflict override #428

Closed
devj3ns opened this issue Aug 29, 2024 · 1 comment
Closed

bug: SupabaseAdapter is missing the onConflict override #428

devj3ns opened this issue Aug 29, 2024 · 1 comment

Comments

@devj3ns
Copy link
Contributor

devj3ns commented Aug 29, 2024

My Customer model has no onConflict specified in the SupabaseSerializable, which results in the following runtime error:

lib/brick/adapters/customer_adapter.g.dart:116:7: Error: The non-abstract class 'CustomerAdapter' is missing implementations for these members:
 - SupabaseAdapter.onConflict

Current behavior: When onConflict is not specified in the SupabaseSerializable, the generator does not override the onConflict field in the OfflineFirstWithSupabaseAdapter.

Expected behavior: The generator overrides the field as follows, when onConflict is not specified:

@override
final onConflict = null;

related: #422

tshedor added a commit that referenced this issue Aug 29, 2024
@tshedor
Copy link
Collaborator

tshedor commented Aug 29, 2024

Fixed and published in #430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants