Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5: Merge dictionaries: add option to dictionary editor to save current filter. #23

Open
sofa13 opened this issue Nov 3, 2016 · 4 comments
Assignees

Comments

@sofa13
Copy link
Collaborator

sofa13 commented Nov 3, 2016

No description provided.

@sofa13 sofa13 self-assigned this Nov 3, 2016
@sofa13
Copy link
Collaborator Author

sofa13 commented Nov 21, 2016

@morinted @Germanika @edalp008 Hey, for the merge of saving current filter etc, where do you think we should add the action? I think the best place would be somewhere in the Editor window, but in that case Ted, I'll need you to design another icon!

icon_option

menu_option

@Germanika
Copy link
Owner

@sofa13 Yeah I think that's a pretty logical place to put it. It could also be useful to let the user select a bunch of entries, then right-click to merge/save-as that selection.

@TheaMorin
Copy link
Collaborator

Good point Ian. I'd say that if we want to put it in the menu bar, then the
dictionary editor should get its own menu bar instead of hitching a ride on
the main window's.

On Nov 22, 2016 12:42 PM, "Ian Germann" [email protected] wrote:

@sofa13 https://github.com/sofa13 Yeah I think that's a pretty logical
place to put it. It could also be useful to let the user select a bunch of
entries, then right-click to merge/save-as that selection.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#23 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFkgSuqEiHb5xoRA0W7F8DOP_0XrViWAks5rAymSgaJpZM4Ko861
.

@sofa13
Copy link
Collaborator Author

sofa13 commented Nov 23, 2016

@Germanika and @morinted Okay great, thanks for your input guys, I agree with the points you both made. I think I'll create a menu bar for the dictionary editor and put the action there, as well as include a right-click to merge/save-as that selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants