Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide policy regarding "write queries". #33

Open
danibishop opened this issue Jan 29, 2019 · 1 comment
Open

Decide policy regarding "write queries". #33

danibishop opened this issue Jan 29, 2019 · 1 comment
Assignees
@josemazo @danibishop @alasarr
Labels
help wanted question
Milestone
v1.0.0

Comments

@danibishop
Copy link

We need to decide if it is 100% up to the user to decide if chache must be used in every specific case or if we try to define a default behavior depending on how the query looks. There is already a ticket regarding this at #20
@danibishop danibishop added this to the v1.0.0 milestone Jan 29, 2019
@danibishop danibishop mentioned this issue Jan 29, 2019
Merged
@josemazo
Copy link
Contributor

On second thoughts, I think the best behavior could be don't cache any query, and use it if the method says so. The developers should be responsible if they cache a write query... maybe it's the behavior they want.

danibishop pushed a commit that referenced this issue Jan 30, 2019
Write query comprobation removed. Closes #33. Use of cache is now con…
a50754f 
…figurable in a per-query basis using a bool parameter in the query() method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josemazo josemazo

@danibishop danibishop

@alasarr alasarr

Labels
help wanted question
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@josemazo @danibishop @alasarr