Codecov Report

Merging #11300 (3bee083) into master (4861375) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #11300   +/-   ##
=======================================
  Coverage   60.55%   60.55%           
=======================================
  Files         846      846           
  Lines       52477    52477           
  Branches     6722     6722           
=======================================
  Hits        31777    31777           
  Misses      19165    19165           
  Partials     1535     1535           

@NyakudyaA the updategeoip functionality was just dropped since it was a very old method that is not allowed anymore by MaxMind EULA.
I think the GEOIP_PATH should be enough to reference the DB location, isn't it?

@NyakudyaA the updategeoip functionality was just dropped since it was a very old method that is not allowed anymore by MaxMind EULA. I think the GEOIP_PATH should be enough to reference the DB location, isn't it?

Not in all cases, in our case we are deploying through ArgoCD and we cannot mount the DB so we would prefer to have a working link to download the DB and if the link is not available/working we can still provide our own custom link to download the DB

Not in all cases, in our case we are deploying through ArgoCD and we cannot mount the DB so we would prefer to have a working link to download the DB and if the link is not available/working we can still provide our own custom link to download the DB

Out of curiosity:

• are you using the monitoring module?
• do you need to execute regular updates of the GeoIP DB?

Not in all cases, in our case we are deploying through ArgoCD and we cannot mount the DB so we would prefer to have a working link to download the DB and if the link is not available/working we can still provide our own custom link to download the DB

Out of curiosity:

* are you using the monitoring module?

* do you need to execute regular updates of the GeoIP DB?

We do use monitoring module. We rarely execute updates on the GeoIP DB. If the updategeoip method has been dropped maybe I can take a look and see if we still need this. Maybe if you can fix the URL to be correct then we can close this PR

Maybe if you can fix the URL to be correct then we can close this PR

@NyakudyaA the GeoIP 2 DB can not be shared, it violates MaxMind EULA. You need your own copy of the DB and set the GEOIP_PATH to your convenience.
If you don't need to do frequent updates you could ship it inside your Docker image.

No longer useful since monitoring has been dropped