Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonConstructors does not work with System.Text.Json #10

Open
MartinCarpentier opened this issue Jan 7, 2022 · 1 comment
Open

JsonConstructors does not work with System.Text.Json #10

MartinCarpentier opened this issue Jan 7, 2022 · 1 comment

Comments

@MartinCarpentier
Copy link
Contributor

MartinCarpentier commented Jan 7, 2022

When converting the features to System.Text.Json support, the JsonConstructors seem to fail, and no easy fix where found.

To make the serialization work, it was required to add a default empty constructor, which meant that object construction could be done in a way which is unintended.

For now this is the only solution, but finding a way to make the JsonConstructors work again would definitely be preferred.

Work:

  • Make JsonConstructors work in the feature classes
  • Remove the empty constructors on the features
@matt-lethargic
Copy link
Member

Could changing the accessibility of the constructor work? Does it need to be public?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants