Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There seems to be some problems in the solver A3CGcnSeq2SeqSolver. #11

Open
wangxichn opened this issue Sep 29, 2023 · 0 comments
Open

Comments

@wangxichn
Copy link

wangxichn commented Sep 29, 2023

First of all, thank you very much for sharing, I learned a lot from your code.
But during my analysis, I noticed some problems in the method "solve" of A3CGcnSeq2SeqSolver class.

In the while loop at line 70 of solver/learning/a3c_gcn_seq2seq/sover.py,
the sub_obs = encoder_obs causes the observations of the subenvironment to be repeatedly refreshed by the old state.
So sub_obs = next_sub_obs at line 90 will have no effect.
The value of next_sub_obs is not used.

It should be correct to write sub_obs = encoder_obs outside the loop to do only the first initialization.

Is my analysis correct? I see Virne also has this problem in your new project, so it's probably not a debugging error.

Thanks again for sharing the code, that's all I was wondering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant