Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stackFrames primitive sets incorrect filename if phu["ORIGNAME"] does not exists. #454

Open
leejjoon opened this issue Apr 28, 2024 · 0 comments
Open

stackFrames primitive sets incorrect filename if phu["ORIGNAME"] does not exists. #454

leejjoon opened this issue Apr 28, 2024 · 0 comments
Labels
bug 🐛 Something should be working but it isn't component - gemini gemini_instruments and geminidr urgency-medium Somewhat normal urgency

Comments

@leejjoon
Copy link

Here is a relevant code.

DRAGONS/geminidr/core/primitives_stack.py

Line 400 in 32aee56

ad_out.orig_filename = ad_out.phu.get('ORIGNAME')

I understand that ORIGNAME can be set by standardizeHeaders primitive. Still, I think it could be better to simply use 'orig_filename' property of adinputs[0], for example, instead of directly accessing the header.
@teald teald added bug 🐛 Something should be working but it isn't urgency-medium Somewhat normal urgency component - gemini gemini_instruments and geminidr labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something should be working but it isn't component - gemini gemini_instruments and geminidr urgency-medium Somewhat normal urgency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leejjoon @teald