Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display only needs to ID the saturated pixels, it should not need to download a BPM #396

Open
KathleenLabrie opened this issue Oct 4, 2022 · 0 comments
Open

display only needs to ID the saturated pixels, it should not need to download a BPM #396

KathleenLabrie opened this issue Oct 4, 2022 · 0 comments
Labels
algorithm Issues relating to algorithms severity-routine Needs to be fixed urgency-low Do when we have a breather

Comments

@KathleenLabrie
Copy link
Contributor

The primitive display (as reduce -r display blah.fits) runs the full addDQ on raw data. This forces a request for a BPM and a calibration association (even a download if using a server) and an attempted to align and add the illumination mask. Neither are needed. display only needs to identify the saturated pixels. It is probably just a case of calling addDQ with different defaults.
@KathleenLabrie KathleenLabrie added algorithm Issues relating to algorithms severity-routine Needs to be fixed urgency-low Do when we have a breather labels Oct 4, 2022
MichaelRFairhurst added a commit to MichaelRFairhurst/DRAGONS that referenced this issue Mar 4, 2023
@MichaelRFairhurst
Fix GeminiDRSoftware#396, display primitive doesn't need BPM or illum…
db90a40 
… mask.
@MichaelRFairhurst MichaelRFairhurst mentioned this issue Mar 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
algorithm Issues relating to algorithms severity-routine Needs to be fixed urgency-low Do when we have a breather
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KathleenLabrie