Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment fails when first frame has no good sources #294

Open
KathleenLabrie opened this issue Aug 10, 2021 · 0 comments
Open

Alignment fails when first frame has no good sources #294

KathleenLabrie opened this issue Aug 10, 2021 · 0 comments
Labels
algorithm Issues relating to algorithms component - infrastructure recipe_system and any other core functionality enhancement Performance or usage improvement

Comments

@KathleenLabrie
Copy link
Contributor

For alignment, the first frame in the list is used as the reference frame by adjustWCSToReference. If using the sources to do the alignment, then when no good sources are found in that first frame the alignment goes wrong. As possible solution would be to check the second frame and use that one as reference instead if it has "good sources".

It is recognized that the user can simply re-ordered the list. Still, it might be nice to have an automatic fallback.

Suggestion from HD7845.

@KathleenLabrie KathleenLabrie added enhancement Performance or usage improvement algorithm Issues relating to algorithms component - infrastructure recipe_system and any other core functionality labels Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Issues relating to algorithms component - infrastructure recipe_system and any other core functionality enhancement Performance or usage improvement
Projects
None yet
Development

No branches or pull requests

1 participant