Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MeasureGapSize class for tests related with QE Correction #108

Open
b1quint opened this issue Dec 29, 2020 · 0 comments
Open

Improve MeasureGapSize class for tests related with QE Correction #108

b1quint opened this issue Dec 29, 2020 · 0 comments
Labels
enhancement Performance or usage improvement

Comments

@b1quint
Copy link
Contributor

b1quint commented Dec 29, 2020

A recent test for QECorrect started to fail. Chris changed the parameters but the reason it is failing is that the test is not performing as expected. See plot below:

local_gap_size_spl_GS-2019B-Q-132-35-001

You can see that the data seems fine, but the functions used to adjust the spectra diverge on the second gap due to the existence of a strong absorption line near the edges.
@b1quint b1quint added the enhancement Performance or usage improvement label Dec 29, 2020
@b1quint b1quint self-assigned this Dec 29, 2020
@b1quint b1quint removed their assignment Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Performance or usage improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@b1quint