Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] activate testnet mode via configuration #33

Open
krtschmr opened this issue Feb 6, 2019 · 1 comment
Open

[proposal] activate testnet mode via configuration #33

krtschmr opened this issue Feb 6, 2019 · 1 comment

Comments

@krtschmr
Copy link

krtschmr commented Feb 6, 2019

i've expected a configuration where we simply say

config.testnet = true

we then don't need to pass arguments into the address generation anymore

def to_serialized_hex(type = :public, network: :bitcoin)

could be changed to

 def to_serialized_hex(type = :public, network:  nil)
   network = config.network unless network

what would be against this idea?

would also benefit for testing purposes

@krtschmr
Copy link
Author

why this won't be merged? it's super useful.

also i propose that testnet is running by default

@q9f q9f added the enhancement label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants