Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow bower naming conventions in the bower.json #1

Open
lkarthee opened this issue Aug 23, 2016 · 0 comments
Open

Follow bower naming conventions in the bower.json #1

lkarthee opened this issue Aug 23, 2016 · 0 comments

Comments

@lkarthee
Copy link

Hi Geertjan,

I have noticed that bower.json files in this repo don't adhere to bower.json specification - https://github.com/bower/spec/blob/master/json.md

sample bower.json in this repo - name is not slug style
{
  "name": "Part-002",
   ...
   ... contents omitted
}
The name of the package as stored in the registry.

1. Must be unique.
2. Should be slug style for simplicity, consistency and compatibility. Example: unicorn-cake
3. Lowercase, a-z, can contain digits, 0-9, can contain dash or dot but not start/end with them.
4. Consecutive dashes or dots not allowed.
5. 50 characters or less. 

A warning will be generated when bower install is run - bower/bower#2242

For newbies - this is confusing because - during first run of bower install they ignore the warning as it gets buried in install log. Subsequent bower install they will see the warning statement alone as dependencies are already installed. Many confuse this warning with error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant