Skip to content

Commit

Permalink
Merge pull request #5275 from GeekyAnts/release/3.4.13-rc.0
Browse files Browse the repository at this point in the history
Release/3.4.13 rc.0
  • Loading branch information
surajahmed committed Aug 17, 2022
2 parents 8ec24ff + 2f3b31c commit 5930fac
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"prettier --write"
]
},
"version": "3.4.12",
"version": "3.4.13-rc.0",
"license": "MIT",
"private": false,
"main": "lib/commonjs/index",
Expand Down
12 changes: 11 additions & 1 deletion src/components/composites/Actionsheet/ActionsheetContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ const Content = memo(
...resolvedProps
} = usePropsResolution('ActionsheetContent', props);

const handleCloseRef = React.useRef(null);
const handleCloseCallback = React.useCallback(() => {
let handleCloseCurrent = handleCloseRef.current;
//@ts-ignore
return handleCloseCurrent();
}, []);
React.useEffect(() => {
handleCloseRef.current = handleClose;
}, [handleClose]);

const panResponder = React.useRef(
PanResponder.create({
onStartShouldSetPanResponder: () => true,
Expand All @@ -48,7 +58,7 @@ const Content = memo(
toValue: { x: 0, y: sheetHeight.current },
duration: 150,
useNativeDriver: true,
}).start(handleClose);
}).start(handleCloseCallback);

setTimeout(() => {
Animated.timing(pan, {
Expand Down
6 changes: 5 additions & 1 deletion src/components/composites/Toast/Toast.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ const CustomToast = ({ _overlay, _stack, _presenceTransition }: any) => {
});

return getPositions().length > 0 ? (
<Overlay {..._overlay} isOpen={hasToastOnOverlay}>
<Overlay
{..._overlay}
isOpen={hasToastOnOverlay}
isKeyboardDismissable={false}
>
{getPositions().map((position: string) => {
if (Object.keys(POSITIONS).includes(position))
return (
Expand Down
2 changes: 2 additions & 0 deletions src/components/primitives/Select/Select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const Select = (
isHovered: isHoveredProp,
isFocused: isFocusedProp,
isFocusVisible: isFocusVisibleProp,
variant,
...props
}: ISelectProps,
ref: any
Expand Down Expand Up @@ -170,6 +171,7 @@ const Select = (
focusable={false}
isDisabled={isDisabled}
pointerEvents="none"
variant={variant}
/>
);

Expand Down

0 comments on commit 5930fac

Please sign in to comment.