Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing and testing improvements #46

Merged
merged 29 commits into from
Aug 13, 2024
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
861e7e3
Added user agent argument (#43)
freddyheppell Aug 7, 2024
aef2f45
types
freddyheppell Aug 8, 2024
bd160ef
ruff
freddyheppell Aug 8, 2024
c411f3e
docs improvements
freddyheppell Aug 8, 2024
e169b5e
update docs
freddyheppell Aug 8, 2024
5c0fcf0
add py.typed
freddyheppell Aug 8, 2024
1acf74a
add type check workflow
freddyheppell Aug 8, 2024
a185ab3
fix paramspec in py3.9
freddyheppell Aug 8, 2024
a53b9d9
add tests for picker select helpers
freddyheppell Aug 8, 2024
0610aa7
more tests for download/parse/extract
freddyheppell Aug 8, 2024
ead3a1e
fix flaky test
freddyheppell Aug 8, 2024
277b5a3
ruff
freddyheppell Aug 9, 2024
db55c70
wpapi crawler tests
freddyheppell Aug 9, 2024
cea25be
remove wpapi caching
freddyheppell Aug 9, 2024
ac8d7ad
test get_obj_list and remove search
freddyheppell Aug 9, 2024
fa95874
more tests
freddyheppell Aug 9, 2024
e4de46a
add e2e tests
freddyheppell Aug 12, 2024
1e13177
add extra info to e2e test docs
freddyheppell Aug 12, 2024
438922f
Merge branch 'release/1.0.4' into typing
freddyheppell Aug 12, 2024
5e49e8e
remove unused UA argument on downloader
freddyheppell Aug 12, 2024
76e4329
ruff
freddyheppell Aug 12, 2024
7825c1d
fix ua null behaviour
freddyheppell Aug 12, 2024
8f10459
ruff
freddyheppell Aug 12, 2024
55cd131
Improve download error handling on first request
freddyheppell Aug 12, 2024
11b4ee7
Revert type change to set_current_lang and instead concat inside extr…
freddyheppell Aug 12, 2024
9b48a24
Update changelog
freddyheppell Aug 12, 2024
87df809
fix incorrect docstring
freddyheppell Aug 12, 2024
ccae085
remove incorrect raises of not v2 error
freddyheppell Aug 12, 2024
730b5d8
requestsession tests
freddyheppell Aug 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix flaky test
freddyheppell committed Aug 8, 2024
commit ead3a1e4fa66abe65b107d3188538453030ea1af
5 changes: 2 additions & 3 deletions tests/scrape/test_crawler.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import json
import logging
from pathlib import Path

@@ -30,9 +31,7 @@ def test_scrape_crawl(shared_datadir):
assert crawl.get_link_abs_path() == expected_link_abs_path(root_path)

assert (root_path / "url_cache.json").is_file()
assert (root_path / "url_cache.json").read_text() == (
shared_datadir / "expected_url_cache.json"
).read_text()
assert json.loads((root_path / "url_cache.json").read_text()) == json.loads((shared_datadir / "expected_url_cache.json" ).read_text())


def test_recrawl_different_version(caplog, shared_datadir: Path):
Loading