Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We Need A Way To Blacklist Plugins #89

Open
greenwoodma opened this issue Jul 3, 2019 · 2 comments
Open

We Need A Way To Blacklist Plugins #89

greenwoodma opened this issue Jul 3, 2019 · 2 comments

Comments

@greenwoodma
Copy link
Contributor

Twitter 8.6 no longer works properly (logic errors rather than exceptions) with GATE 8.7-SNAPSHOT or above but there is no way of flagging that to users. It would be nice to have a list of blacklisted plugins to prevent such issues. Probably a file like the metadata fils that list versions known not to work

@johann-petrak
Copy link
Contributor

So if a plugin version about to be loaded is found on the blacklist, what would we want to happen? Throw an exception? Just logging a warning might be easy to overlook in some cases. Maybe throw an exception unless a property or environment variable is set to deliberately override?
Do we want to notice when a blacklisted version wants to get loaded after another non-listed version already has been loaded because then the working version would still get used, right?

@greenwoodma
Copy link
Contributor Author

I'd want to make it impossible to load the plugin at all. It either wouldn't show up or would be an error in the plugin manager and so not manually loadable. If you tried to load an app that referenced it I'd want that to throw an exception and stop (just as if the plugin didn't exist) probably with a message to use the xgapp upgrade tool to move to a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants