Raise an exception in case of excess fields

In the case when user passed a misstyped column name (e.g. 'metadat'), a warning won't be sufficient as the result is unpredictable

Author: igiloh-pinecone

pinecone/core/grpc/index_grpc.py

@@ -3,7 +3,6 @@
 #
 import logging
 import numbers
-import warnings
 from abc import ABC, abstractmethod
 from functools import wraps
 from typing import NamedTuple, Optional, Dict, Iterable, Union, List, Tuple, Any
@@ -340,8 +339,8 @@ def _dict_to_grpc_vector(item):
 
             excessive_keys = item_keys - (REQUIRED_VECTOR_FIELDS | OPTIONAL_VECTOR_FIELDS)
             if len(excessive_keys) > 0:
-                warnings.warn(f"Found excessive keys in the vector dictionary: {list(excessive_keys)}. "
-                              f"These keys will be ignored. The allowed keys are: {list(REQUIRED_VECTOR_FIELDS | OPTIONAL_VECTOR_FIELDS)}")
+                raise ValueError(f"Found excess keys in the vector dictionary: {list(excessive_keys)}. "
+                                 f"The allowed keys are: {list(REQUIRED_VECTOR_FIELDS | OPTIONAL_VECTOR_FIELDS)}")
 
             sparse_values = None
             if 'sparse_values' in item:
@@ -377,7 +376,7 @@ def _vector_transform(item):
                 if len(item) > 3:
                     raise ValueError(f"Found a tuple of length {len(item)} which is not supported. " 
                                      f"Vectors can be represented as tuples either the form (id, values, metadata) or (id, values). "
-                                     f"To pass sparse values please use either dicts or a GRPCVector objects as inputs.")
+                                     f"To pass sparse values please use either dicts or GRPCVector objects as inputs.")
                 id, values, metadata = fix_tuple_length(item, 3)
                 return GRPCVector(id=id, values=values, metadata=dict_to_proto_struct(metadata) or {})
             elif isinstance(item, Mapping):

pinecone/index.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2020-2021 Pinecone Systems Inc. All right reserved.
 #
 import numbers
-import warnings
 
 from tqdm import tqdm
 from collections.abc import Iterable, Mapping
@@ -174,8 +173,8 @@ def _dict_to_vector(item):
 
             excessive_keys = item_keys - (REQUIRED_VECTOR_FIELDS | OPTIONAL_VECTOR_FIELDS)
             if len(excessive_keys) > 0:
-                warnings.warn(f"Found excessive keys in the vector dictionary: {list(excessive_keys)}. "
-                              f"These keys will be ignored. The allowed keys are: {list(REQUIRED_VECTOR_FIELDS | OPTIONAL_VECTOR_FIELDS)}")
+                raise ValueError(f"Found excess keys in the vector dictionary: {list(excessive_keys)}. "
+                                 f"The allowed keys are: {list(REQUIRED_VECTOR_FIELDS | OPTIONAL_VECTOR_FIELDS)}")
 
             sparse_values = None
             if 'sparse_values' in item: