Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USD CMake files included into the manifest #240

Open
boberfly opened this issue Jun 10, 2023 · 1 comment
Open

USD CMake files included into the manifest #240

boberfly opened this issue Jun 10, 2023 · 1 comment

Comments

@boberfly
Copy link
Contributor

Before I forget again, could we bring in the USD cmake stuff into the manifest? I found that I needed it to build USD-related stuff against the Gaffer releases and it needed these things.

I believe it is:
pxrConfig.cmake
cmake/pxrTargets.cmake
cmake/pxrTargets-release.cmake

It looks a bit messy in the root directory if that's a concern, I wonder if we could massage them into the lib/ directory like the other cmake stuff and run a sed over the pathing...

@johnhaddon
Copy link
Member

Sounds reasonable to me, but I'd really like to avoid cluttering up the top-level directory namespace. I'd also be concerned that some .cmake files might be baking full paths in (I saw that with MaterialX), so wouldn't be relocatable as is needed when people install Gaffer. Happy to accept a PR if those two specific issues can be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants