Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Continue Fixing Graph Bugs #123

Open
2 tasks
johannesq23 opened this issue Sep 17, 2024 · 0 comments
Open
2 tasks

[Frontend] Continue Fixing Graph Bugs #123

johannesq23 opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels

Comments

@johannesq23
Copy link
Contributor

johannesq23 commented Sep 17, 2024

Context

We want to continue fixing the graph bugs for the patient analytics. I did not merge in your previous pr so if you want to go off of that feel free to.

Requirements

Refer to the new design here.

Screen.Recording.2024-09-19.at.14.34.05.mov

Here are some specifics on what to add.

  • X-Axis and Y-Axis lines are drawn.
  • Side values are integers, One method: Take the max value, and divide.
  • Pop up view rounds to two decimals, notice the new pop-up view and the faint highlight when hovering.
  • Move percent increase/decrease from side of title to top right corner.

The default graph values can be changed here src/utils/patients.ts. Didn't catch this in the previous sprint.
Let me know if you have further design questions

To Note:

  • Font size change (every visible text are 16pt)
  • x and y axis unit added

Acceptance Criteria

  • Graph Components now match the video.
  • Line Graph bug from previous sprint is investigated/fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants