Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET /meals?category= #27

Closed
ranasobeid95 opened this issue Sep 19, 2019 · 0 comments
Closed

GET /meals?category= #27

ranasobeid95 opened this issue Sep 19, 2019 · 0 comments
Assignees
@SajedaIsmail
Labels
Backend This issue/PR is related to Backend project Done The technical tasks related to this issue are done

Comments

@ranasobeid95
Copy link
Collaborator

ranasobeid95 commented Sep 19, 2019 •
edited
Loading

Relates #17
Relates #23

  • Handel route /meals?category=
  • request header will contain the category name
  • Create a query to get meals from the database dependent on category name
  • send a response with data meals as
{code: Number, data: ArrayOfObject  }   // array of objects that will contain all meals of that category
@ahmedisam99 ahmedisam99 added To do This issue represents a technical task that is yet to be started on Backend This issue/PR is related to Backend project labels Sep 21, 2019
@SajedaIsmail SajedaIsmail added In progress This issue/PR represents a technical task that is currently being worked on and removed To do This issue represents a technical task that is yet to be started on labels Sep 22, 2019
SajedaIsmail added a commit that referenced this issue Sep 24, 2019
@SajedaIsmail
Handel route /meals?category=
48c0483 
request header will contain the category name
Create a query to get meals from the database dependent on category name
send a response with data meals as
{code: Number, data: ArrayOfObject  }
Relates #27
SajedaIsmail added a commit that referenced this issue Sep 24, 2019
@SajedaIsmail
Handle the route get /meals?category=
fc557e2 
handle the error from that route
make tet for that route
Relates #27
SajedaIsmail added a commit that referenced this issue Sep 24, 2019
@SajedaIsmail
Change map to forEach
b519661 
Relates #27
SajedaIsmail added a commit that referenced this issue Sep 24, 2019
@SajedaIsmail
the 1=1 test is removed
97b5798 
Relates #27
SajedaIsmail added a commit that referenced this issue Sep 24, 2019
@SajedaIsmail
Give a default value to the category query
8bd6467 
Relates #27
SajedaIsmail added a commit that referenced this issue Sep 24, 2019
@SajedaIsmail
The error message is changed
320dd9d 
Relates #27
SajedaIsmail added a commit that referenced this issue Sep 24, 2019
@SajedaIsmail
code is changed to statusCode in each response body
016e25b 
Relates #27
SajedaIsmail added a commit that referenced this issue Sep 24, 2019
@SajedaIsmail
The category name is returned in the response
ab11199 
Relates #27
SajedaIsmail added a commit that referenced this issue Sep 24, 2019
@SajedaIsmail
Fix eslint errors
5c95ff7 
Relates #27
SajedaIsmail added a commit that referenced this issue Sep 24, 2019
@SajedaIsmail
Delete res.status for 200
0b5ec3a 
Move require to above the router def.
Relates #27
SajedaIsmail added a commit that referenced this issue Sep 25, 2019
@SajedaIsmail
The requested changes are done
42c3b2f 
Remove onFinish line
Remove module.exports
Relates #27
@SajedaIsmail SajedaIsmail added Done The technical tasks related to this issue are done and removed In progress This issue/PR represents a technical task that is currently being worked on labels Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SajedaIsmail SajedaIsmail

Labels
Backend This issue/PR is related to Backend project Done The technical tasks related to this issue are done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SajedaIsmail @ahmedisam99 @ranasobeid95