Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending message data to daily and user_daily stats #2199

Open
Tracked by #2171
heyitsmebev opened this issue Dec 10, 2024 · 4 comments · May be fixed by #2250 or GSA/notifications-api#1493
Open
Tracked by #2171

Add pending message data to daily and user_daily stats #2199

heyitsmebev opened this issue Dec 10, 2024 · 4 comments · May be fixed by #2250 or GSA/notifications-api#1493
Assignees

Comments

@heyitsmebev
Copy link
Contributor

heyitsmebev commented Dec 10, 2024

Currently, the Recent Activity table displays only the counts for delivered and failed messages. We aim to include the count of pending messages to provide a clearer representation of the daily messages sent.

image

Backend work:

Please update these endpoints to also have "pending" count
get_service_notification_statistics_by_day
"/service/{0}/statistics/{1}/{2}".format(service_id, start_date, days)
get_user_service_notification_statistics_by_day
/service/{0}/statistics/user/{1}/{2}/{3}".format(service_id, user_id, start_date, days),

Frontend work:

Display pending stats to chart

@heyitsmebev
Copy link
Contributor Author

@jonathanbobel researching/providing color options for pending that is accessible
@heyitsmebev will coordinate to get "pending" into the endpoint with backend dev and update the chart

@heyitsmebev heyitsmebev moved this from 🌱 New to ⬇ Up-Next in Notify.gov product board Dec 13, 2024
@heyitsmebev heyitsmebev moved this from ⬇ Up-Next to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Dec 19, 2024
@heyitsmebev heyitsmebev linked a pull request Jan 7, 2025 that will close this issue
3 tasks
@heyitsmebev
Copy link
Contributor Author

Note to bev: fix this pending bar that is out of table
Image

@heyitsmebev
Copy link
Contributor Author

heyitsmebev commented Jan 7, 2025

Note to bev:
These pending numbers are not always the same.
One is based on the count based on notification status = pending, created, and sending.
The other pending is based on requested - delivered - failed = pending

  • Do I want to make them the same? Which method of calculations do I want to base them on?
    Image
  • Does the notification_status account for all notifications with a pending status from multiple jobs within a service?
    Image Update: Two jobs have started processing, but the notification status count is accounting for the pending status of only one job. The job that it counts for does show up accurate in both pending within the endpoint and notification_sending on the job's page

@heyitsmebev
Copy link
Contributor Author

requested and notification_count are different numbers. Because they are different, the job page will show a notification_count of 500, while the dashboard (using the daily stats endpoint) will display the value of requested as it updates in _update_statuses_from_row. The requested value is slow to retrieve than notification_count.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress (WIP: ≤ 3 per person)
2 participants