Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher field is not recording metadata publisher correctly #4967

Open
tdlowden opened this issue Nov 6, 2024 · 2 comments
Open

Publisher field is not recording metadata publisher correctly #4967

tdlowden opened this issue Nov 6, 2024 · 2 comments
Labels
bug Software defect or bug component/catalog Related to catalog component playbooks/roles

Comments

@tdlowden
Copy link
Member

tdlowden commented Nov 6, 2024

When we implemented a dataLayer push in the HTML of dataset pages, we included fields for both organization and publisher:

Image

The publisher field is producing the acronym org code, rather than actual publisher, which for the screenshot above, is Farm Service Agency, Department of Agriculture:

Image

How to reproduce

  1. Visit a dataset page
  2. View Source Code and see publisher in the dataLayer push
  3. compare to dataset page UI publisher

Expected behavior

The dataLayer publisher field collects the correct publisher

Actual behavior

The dataLayer publisher field collects the org acronym code

Sketch

TBD

@tdlowden tdlowden added the bug Software defect or bug label Nov 6, 2024
@tdlowden tdlowden moved this to 📟 Sprint Backlog [7] in data.gov team board Nov 6, 2024
@tdlowden tdlowden moved this from 📟 Sprint Backlog [7] to 📥 Queue in data.gov team board Nov 7, 2024
@hkdctol hkdctol added the component/catalog Related to catalog component playbooks/roles label Nov 7, 2024
@hkdctol hkdctol moved this to 📥 Queue in data.gov team board Nov 7, 2024
@jbrown-xentity
Copy link
Contributor

Publisher is a DCAT-US field, and as such isn't consistently there. We can still use it somewhat, but we might have to roll to another option (or leave it blank if not there).

@tdlowden
Copy link
Member Author

Sure. We do neither currently, though. Ideal scenario would be something like

IF publisher exists, record it in the publisher field
ELSE leave null

Then i can deal with null in GA separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software defect or bug component/catalog Related to catalog component playbooks/roles
Projects
Status: 📥 Queue
Development

No branches or pull requests

3 participants