Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug - change method attribute #1501

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix bug - change method attribute #1501

merged 1 commit into from
Jan 7, 2025

Conversation

jairoanaya
Copy link
Contributor

Description

Fixing a bug on deleting a challenge announcement banner.

Related Issues

on deleting a challenge announcement banner.

Changes Made

  • Change Post Method by Get.

Screenshots (if applicable)

Evidence removal 1 Evidence removal 2

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
    ~- [] I have added unit tests for new functionality or updated existing tests for changes.
    - [ ] I have updated the documentation/README accordingly, if necessary.
    - [ ] If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
    - [ ] If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.
  • Build has been approved for deployment in CircleCI.

@jairoanaya jairoanaya added this to the Sprint 01/14/25 milestone Jan 7, 2025
@jairoanaya jairoanaya requested a review from kkrug January 7, 2025 00:14
@jairoanaya jairoanaya self-assigned this Jan 7, 2025
@r-bartlett-gsa r-bartlett-gsa linked an issue Jan 7, 2025 that may be closed by this pull request
Announcement Removal Bug #1490
Open
32 tasks
@kkrug kkrug merged commit 2881071 into staging Jan 7, 2025
5 checks passed
@kkrug kkrug deleted the 1490-announcement-removal-bug-from-staging branch January 7, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrug kkrug kkrug approved these changes

Assignees

@jairoanaya jairoanaya

Labels
None yet
Projects
None yet
Milestone
Sprint 01/14/25
Development

Successfully merging this pull request may close these issues.

Announcement Removal Bug
2 participants
@jairoanaya @kkrug