Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails deployment should merge old and new assets #132

Open
3 tasks done
rahearn opened this issue Jan 2, 2025 · 3 comments · May be fixed by #133
Open
3 tasks done

Rails deployment should merge old and new assets #132

rahearn opened this issue Jan 2, 2025 · 3 comments · May be fixed by #133
Assignees

Comments

@rahearn
Copy link
Contributor

rahearn commented Jan 2, 2025

Story

As a devops engineer,
I would like to deploy an update that can serve old assets,
So that I can have a true zero-downtime deploy that doesn't break in-flight requests

Inspired by https://kamal-deploy.org as well as some pain points we hit on the covid tests backup deploys

Solution

Tasks

Preview Give feedback

Acceptance Criteria

  • Deploying asset updates allows for the app to serve both new and old digest fingerprints
@rahearn rahearn self-assigned this Jan 2, 2025
@rahearn
Copy link
Contributor Author

rahearn commented Jan 2, 2025

Blocked until cloudfoundry/ruby-buildpack#1006 has been merged, released, and in cloud.gov's default buildpacks list.

Not fully blocked, we can still have the default clean behavior even without that PR being released

@rahearn
Copy link
Contributor Author

rahearn commented Jan 3, 2025

Current issues:

  • need to deploy at least 1/week to prevent cache eviction, need a fallback
  • potential issues in high-turnover assets falling off the 1.hour clean cutoff between plan and apply resulting in failed deploys
  • need to add a key to the cache name to force upload when files change (hash .manifest.json?)

@rahearn
Copy link
Contributor Author

rahearn commented Jan 6, 2025

Issues of failed applies due to assets falling off the 1.hour cutoff left as an exercise for the implementing team, and maybe to revisit in the future in gitlab ci

@rahearn rahearn linked a pull request Jan 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant