From 95668abf3ed0b6bf70494a991f88d7e2281bcf86 Mon Sep 17 00:00:00 2001 From: Alex Steel <130377221+asteel-gsa@users.noreply.github.com> Date: Mon, 8 Jul 2024 15:05:40 -0400 Subject: [PATCH 1/2] add only_changed_files: true (#4052) --- .github/workflows/testing-from-build.yml | 1 + .github/workflows/testing-from-ghcr.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/testing-from-build.yml b/.github/workflows/testing-from-build.yml index 61b6c2e33..bbfce0563 100644 --- a/.github/workflows/testing-from-build.yml +++ b/.github/workflows/testing-from-build.yml @@ -55,6 +55,7 @@ jobs: skip_covered: true # Set to true to remove 100% covered from report fail_below_threshold: false # Fails the action if 90% threshold is not met show_missing: true + only_changed_files: true repo_token: ${{ secrets.GITHUB_TOKEN }} # a11y-testing: diff --git a/.github/workflows/testing-from-ghcr.yml b/.github/workflows/testing-from-ghcr.yml index 98379c5a1..6c7a5d4c3 100644 --- a/.github/workflows/testing-from-ghcr.yml +++ b/.github/workflows/testing-from-ghcr.yml @@ -57,6 +57,7 @@ jobs: skip_covered: true # Set to true to remove 100% covered from report fail_below_threshold: false # Fails the action if 90% threshold is not met show_missing: true + only_changed_files: true repo_token: ${{ secrets.GITHUB_TOKEN }} # a11y-testing: From 4761ee96f8101fbf29249f821394d6da2bd661be Mon Sep 17 00:00:00 2001 From: Alex Steel <130377221+asteel-gsa@users.noreply.github.com> Date: Mon, 8 Jul 2024 17:04:28 -0400 Subject: [PATCH 2/2] Coverage report patch (#4060) * Explicitly set the report to go to PR * backing out * Test a new coverage tool * Swap coverage actions --- .github/workflows/testing-from-build.yml | 14 +++++--------- .github/workflows/testing-from-ghcr.yml | 14 +++++--------- 2 files changed, 10 insertions(+), 18 deletions(-) diff --git a/.github/workflows/testing-from-build.yml b/.github/workflows/testing-from-build.yml index bbfce0563..647b3897f 100644 --- a/.github/workflows/testing-from-build.yml +++ b/.github/workflows/testing-from-build.yml @@ -47,16 +47,12 @@ jobs: pwd ls -al | grep 'coverage' - - name: Publish Coverage Report to Pull Request - uses: 5monkeys/cobertura-action@master + - name: Coverage Action + if: github.event_name == 'pull_request' + uses: orgoro/coverage@v3.1 with: - path: ./coverage.xml - minimum_coverage: 85 - skip_covered: true # Set to true to remove 100% covered from report - fail_below_threshold: false # Fails the action if 90% threshold is not met - show_missing: true - only_changed_files: true - repo_token: ${{ secrets.GITHUB_TOKEN }} + coverageFile: ./coverage.xml + token: ${{ secrets.GITHUB_TOKEN }} # a11y-testing: # runs-on: ubuntu-latest diff --git a/.github/workflows/testing-from-ghcr.yml b/.github/workflows/testing-from-ghcr.yml index 6c7a5d4c3..009a390b8 100644 --- a/.github/workflows/testing-from-ghcr.yml +++ b/.github/workflows/testing-from-ghcr.yml @@ -49,16 +49,12 @@ jobs: pwd ls -al | grep 'coverage' - - name: Publish Coverage Report to Pull Request - uses: 5monkeys/cobertura-action@master + - name: Coverage Action + if: github.event_name == 'pull_request' + uses: orgoro/coverage@v3.1 with: - path: ./coverage.xml - minimum_coverage: 85 - skip_covered: true # Set to true to remove 100% covered from report - fail_below_threshold: false # Fails the action if 90% threshold is not met - show_missing: true - only_changed_files: true - repo_token: ${{ secrets.GITHUB_TOKEN }} + coverageFile: ./coverage.xml + token: ${{ secrets.GITHUB_TOKEN }} # a11y-testing: # runs-on: ubuntu-latest