Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing context parameter defines for HybridPro.dll #61

Open
NeoSpark314 opened this issue Mar 12, 2023 · 1 comment
Open

Missing context parameter defines for HybridPro.dll #61

NeoSpark314 opened this issue Mar 12, 2023 · 1 comment

Comments

@NeoSpark314
Copy link

When iterating through all parameters of a rpr_context created with the HybridPro.dll plugin I get many parameters that have no #define yet in RadeonProRender.h. They are also missing in the utility class RPRStringIDMapper. The full output I get (including the RPR_PARAMETER_DESCRIPTION) is below. The parameters starting with id 0x1001 seem to be missing from the header.

INFO: Creating RadeonProRender Version 3.1.0 (Build a9c8434)
All parameters (count = 54):
  iterations (id = 0x10b; desc = 'Number of iterations performed for current render') = 1
  tonemapping.photolinear.sensitivity (id = 0x115; desc = 'Sensitivity if photo tonemapper selected') = 1.000000
  tonemapping.photolinear.exposure (id = 0x116; desc = 'Exposure if photo tonemapper selected') = 0.125000
  tonemapping.photolinear.fstop (id = 0x117; desc = 'FStop if photo tonemapper selected') = 1.000000
  maxrecursion (id = 0x11b; desc = 'Ray trace depth') = 21
  raycastepsilon (id = 0x11c; desc = 'Ray cast epsilon') = 0.001000
  radianceclamp (id = 0x11d; desc = 'Clamp radiance') = 50.000000
  xflip (id = 0x11e; desc = 'Flip framebuffer output along X axis') = 0
  yflip (id = 0x11f; desc = 'Flip framebuffer output along Y axis') = 1
  displaygamma (id = 0x124; desc = 'Display gamma') = 1.000000
  framecount (id = 0x131; desc = 'Frame number') = 0
  maxdepth.diffuse (id = 0x138; desc = 'Diffuse ray trace depth') = 5
  maxdepth.glossy (id = 0x139; desc = 'Reflection ray trace depth') = 5
  maxdepth.refraction (id = 0x13b; desc = 'Refraction ray trace depth') = 5
  maxdepth.refraction.glossy (id = 0x13c; desc = 'Refraction ray trace depth') = 5
  aaenabled (id = 0x166; desc = 'Enable anti-aliasing') = 1
  pluginversion (id = 0x16b; desc = 'Get the version of the plugin DLL attached to the RPR API. Constant value.') = 3552402737
  ocioconfigpath (id = 0x171; desc = 'OpenColorIO config path') = ''
  ociorenderingcolorspace (id = 0x172; desc = 'OpenColorIO destination color space') = ''
  randseed (id = 0x1000; desc = 'Random seed') = 0

   (id = 0x1001; desc = 'Render quality') = 2
   (id = 0x1002; desc = 'Number of prerendered frames. Must not be less than 2') = 2
   (id = 0x1006; desc = 'Enable TAA samples accumulation') = 0
   (id = 0x1007; desc = 'Enable path tracing upscale') = 0
   (id = 0x1008; desc = 'Path tracing upscale factor') = 1.000000
   (id = 0x100c; desc = 'Enable using lightmaps') = 0
   (id = 0x1011; desc = 'Stereo Render') = 0
   (id = 0x1012; desc = 'Enable hierarchical light sampling') = 1
   (id = 0x1013; desc = 'Arithmetics support') = 0
   (id = 0x1014; desc = 'Number of camera jitter points') = 8
   (id = 0x1015; desc = 'Use MSAA instead of TAA') = 0
   (id = 0x101e; desc = 'Traversal mode configuration') = 0
   (id = 0x1022; desc = 'strict/relaxed material checks') = 0
   (id = 0x102d; desc = 'Path tracing denoiser type') = 0
   (id = 0x102e; desc = 'Maximum textures available') = 512
   (id = 0x102f; desc = 'Enable reservoir sampling') = 0
   (id = 0x1030; desc = 'Exposure') = 1.000000
   (id = 0x1031; desc = 'Enable tone mapping') = 0
   (id = 0x1033; desc = 'ReSTIR GI') = 0
   (id = 0x1034; desc = 'Path Space Regularization: Attenuation factor for roughness. [0.0, 1.0], 0.0 - Unbiased, high variance, 1.0 - Biased, low variance') = 0.000000
   (id = 0x1035; desc = 'Reduce overall shaders compilation time, in some cases can increase performance, especially on complex materials') = 0
   (id = 0x1036; desc = 'Enable Rasterization') = 0
   (id = 0x1037; desc = 'World space ReSTIR spatial resample iteration count') = 3
   (id = 0x1038; desc = 'Max reservoirs per world space hash grid cell') = 128
   (id = 0x1039; desc = 'Enable half-res indirect') = 0
   (id = 0x1003b; desc = 'Enable Radiance Cache') = 0
   (id = 0x1003c; desc = 'Set ReSTIR GI bias correction method') = 2
   (id = 0x1003d; desc = 'Enable sample validation which helps to remove temporal lag of indirect lighting at the cost of decreased performance') = 1
   (id = 0x1003e; desc = 'Enable motion blur') = 0
   (id = 0x1003f; desc = 'Sample count for motion blur') = 8
   (id = 0x10040; desc = 'Enable Median Of meaNs for accumulation in ground truth') = 0
   (id = 0x10041; desc = 'Gini coefficient threshold used in Median Of meaNs ') = 0.250000
   (id = 0x10042; desc = 'Upscaler algorithm') = 0
   (id = 0x10043; desc = 'FSR2 quality') = 0
@ARozghon
Copy link

hi, some parameters have not yet been implemented to RPR USD Hydra for Houdini.
will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants