Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Typescript commponents level prop does not include primary #111

Open
smithjw1 opened this issue Mar 10, 2023 · 2 comments
Open

Button Typescript commponents level prop does not include primary #111

smithjw1 opened this issue Mar 10, 2023 · 2 comments

Comments

@smithjw1
Copy link

The current props are

type Props = {
  disabled?: boolean;
  level: 'secondary' | 'warning';
  name?: string;
  type?: React.ButtonHTMLAttributes<HTMLButtonElement>['type'];
  onClick?: React.ButtonHTMLAttributes<HTMLButtonElement>['onClick'];
  children?: React.ReactNode;
};

Since level is required, and it can not be set to "primary" there is no valid way in TypeScript to use a Primary button.

@smithjw1
Copy link
Author

I have a commit all ready to go, but without write permissions to the repo, I can't create a PR without a fork. Happy to go that way if it is preferred.

@michalkleiner
Copy link

Usually, in the open-source world, it's common to raise a PR from a fork and then delete the branch or the whole repo (if not needed anymore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants