[6주차 과제] 서버 통신 심화 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1urrrr
requested changes
Jun 5, 2023
Comment on lines
48
to
54
| is Success -> { | ||
| followerAdapter?.submitList(viewModel.followerList) | ||
| if(loadingDialog.isShowing) loadingDialog.dismiss() | ||
| } | ||
| is Failure -> requireContext().showSnackbar( | ||
| binding.root, | ||
| getString(R.string.gallery_follower_list_null_msg) |
There was a problem hiding this comment.
Failure인 경우에도 LoadingDialog를 dismiss 해주는 것이 좋을 것 같습니다!
| return pw.isNotBlank() && pw.length in MIN_PW_LENGTH..MAX_PW_LENGTH | ||
| // 영문, 숫자, 특수문자를 적어도 하나씩 포함하는 6~12자리 문자열 | ||
| // 허용되는 특수 문자: !, @, #, $, %, ^, +, -, = | ||
| val pwRegex = """^(?=.*[A-Za-z])(?=.*\d)(?=.*[!@#$%^+\-=])[A-Za-z\d!@#$%^+\-=]{6,12}$""" |
There was a problem hiding this comment.
Suggested change
| val pwRegex = """^(?=.*[A-Za-z])(?=.*\d)(?=.*[!@#$%^+\-=])[A-Za-z\d!@#$%^+\-=]{6,12}$""" | |
| val pwRegex = """^(?=.*[A-Za-z])(?=.*\d)(?=.*[!@#$%^+\-=])[A-Za-z\d!@#$%^+\-=]{MIN_PW_LENGTH,MAX_PWD_LENGTH}$""" |
정규식에 상수를 사용하는 것이 보일러플레이트를 줄일 수 있을 것 같습니다!
Comment on lines
56
to
65
| fun isNotBlankName(): Boolean { | ||
| return name.isNotBlank() | ||
| } | ||
|
|
||
| fun isNotBlankHobby(): Boolean { | ||
| return hobby.isNotBlank() | ||
| } | ||
|
|
||
| fun isValidInput(): Boolean { | ||
| return isValidId() && isValidPw() && isNotBlankName() && isNotBlankHobby() |
There was a problem hiding this comment.
Suggested change
| fun isNotBlankName(): Boolean { | |
| return name.isNotBlank() | |
| } | |
| fun isNotBlankHobby(): Boolean { | |
| return hobby.isNotBlank() | |
| } | |
| fun isValidInput(): Boolean { | |
| return isValidId() && isValidPw() && isNotBlankName() && isNotBlankHobby() | |
| fun isNotBlankName() = name.isNotBlank() | |
| fun isNotBlankHobby() = hobby.isNotBlank() | |
| fun isValidInput() = isValidId() && isValidPw() && isNotBlankName() && isNotBlankHobby() |
single expression 함수로 구현하면 조금 더 깔끔할 것 같습니다!
Comment on lines
30
to
58
| binding.etId.addTextChangedListener { | ||
| if (!viewModel.isValidId()) { | ||
| binding.tilId.error = getString(R.string.sign_up_id_helper_text) | ||
| deactivateSignUpButton() | ||
| } else { | ||
| binding.tilId.error = null | ||
| if (viewModel.isValidInput()) activateSignUpButton() | ||
| } | ||
| } | ||
|
|
||
| binding.etPw.addTextChangedListener { | ||
| if (!viewModel.isValidPw()) { | ||
| binding.tilPw.error = getString(R.string.sign_up_pw_helper_text) | ||
| deactivateSignUpButton() | ||
| } else { | ||
| binding.tilPw.error = null | ||
| if (viewModel.isValidInput()) activateSignUpButton() | ||
| } | ||
| } | ||
|
|
||
| binding.etName.addTextChangedListener { | ||
| if (viewModel.isNotBlankName()) { | ||
| binding.tilName.error = null | ||
| if (viewModel.isValidInput()) activateSignUpButton() | ||
| } else { | ||
| binding.tilName.error = getString(R.string.sign_up_required_input_err) | ||
| deactivateSignUpButton() | ||
| } | ||
| } |
There was a problem hiding this comment.
TextChangedListener를 설정할 때 유사한 로직이 반복되고 있는데, InputEditText와 Boolean 타입의 조건을 인자로 받는 함수를 만들어 사용할 수도 있을 것 같습니다!
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:inputType="textPassword" | ||
| android:singleLine="true" |
There was a problem hiding this comment.
singleLine 속성은 deprecated된 속성이기 때문에 maxLines를 활용하는 것이 좋을 것 같습니다!
Comment on lines
71
to
77
| private fun activateSignUpButton() { | ||
| binding.btnSignUp.isEnabled = true | ||
| } | ||
|
|
||
| private fun deactivateSignUpButton() { | ||
| binding.btnSignUp.isEnabled = false | ||
| } |
There was a problem hiding this comment.
이것도 데이터바인딩이나 바인딩 어댑터를 활용하여 처리하면 코드를 좀 줄일 수 있을 것 같습니다!
lsakee
reviewed
Jun 5, 2023
Comment on lines
30
to
58
| binding.etId.addTextChangedListener { | ||
| if (!viewModel.isValidId()) { | ||
| binding.tilId.error = getString(R.string.sign_up_id_helper_text) | ||
| deactivateSignUpButton() | ||
| } else { | ||
| binding.tilId.error = null | ||
| if (viewModel.isValidInput()) activateSignUpButton() | ||
| } | ||
| } | ||
|
|
||
| binding.etPw.addTextChangedListener { | ||
| if (!viewModel.isValidPw()) { | ||
| binding.tilPw.error = getString(R.string.sign_up_pw_helper_text) | ||
| deactivateSignUpButton() | ||
| } else { | ||
| binding.tilPw.error = null | ||
| if (viewModel.isValidInput()) activateSignUpButton() | ||
| } | ||
| } | ||
|
|
||
| binding.etName.addTextChangedListener { | ||
| if (viewModel.isNotBlankName()) { | ||
| binding.tilName.error = null | ||
| if (viewModel.isValidInput()) activateSignUpButton() | ||
| } else { | ||
| binding.tilName.error = getString(R.string.sign_up_required_input_err) | ||
| deactivateSignUpButton() | ||
| } | ||
| } |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
필수 과제
심화 과제
도전 과제
실행 결과
Screen_Recording_20230604_135452_GO.SOPT.Android.mp4
리팩토링 TODO