[1주차 과제] 안드로이드 UI 구현 기초 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1urrrr
requested changes
Apr 7, 2023
Comment on lines
25
to
69
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| binding = ActivityLoginBinding.inflate(layoutInflater) | ||
| setContentView(binding.root) | ||
|
|
||
| // SharedPreferences에 저장된 유저 정보가 있으면 메인 화면으로 진입 | ||
| if (isLastUserLoggedIn()) { | ||
| navigateToMainScreen() | ||
| } | ||
|
|
||
| binding.root.setOnClickListener { | ||
| hideKeyboard() | ||
| } | ||
|
|
||
| // 회원가입 화면으로부터 유저 정보 가져오기 | ||
| resultLauncher = registerForActivityResult( | ||
| ActivityResultContracts.StartActivityForResult() | ||
| ) { result -> | ||
| if (result.resultCode == RESULT_OK) { | ||
| Snackbar.make(binding.root, SIGN_UP_SUCCESS_MSG, Snackbar.LENGTH_SHORT).show() | ||
| registerUserInfo(result.data) | ||
|
|
||
| // 자동 로그인을 위해 SharedPreferences에 유저 정보 저장하기 | ||
| saveUserInfoToPrefs() | ||
| } | ||
| } | ||
|
|
||
| binding.btnLogin.setOnClickListener { | ||
| if (userRegisteredStatus) { | ||
| if (checkInputValues()) { | ||
| Toast.makeText(this, LOGIN_SUCCESS_MSG, Toast.LENGTH_SHORT).show() | ||
| navigateToMainScreen() | ||
| } else { | ||
| Toast.makeText(this, LOGIN_FAIL_MSG, Toast.LENGTH_SHORT).show() | ||
| } | ||
| } else { | ||
| Toast.makeText(this, NOT_YET_REGISTERED_MSG, Toast.LENGTH_SHORT).show() | ||
| } | ||
| } | ||
|
|
||
| binding.btnSignUp.setOnClickListener { | ||
| val intent = Intent(this, SignUpActivity::class.java) | ||
| resultLauncher.launch(intent) | ||
| } | ||
| } |
There was a problem hiding this comment.
onCreate() 함수에 로직이 몰려 있는 것 같습니다!
함수화를 통해 로직을 분리해주시면 가독성도 좋아지고 onCreate의 역할을 덜어줄 수 있어 좋을 것 같습니다 🙃
Comment on lines
55
to
61
| Toast.makeText(this, LOGIN_SUCCESS_MSG, Toast.LENGTH_SHORT).show() | ||
| navigateToMainScreen() | ||
| } else { | ||
| Toast.makeText(this, LOGIN_FAIL_MSG, Toast.LENGTH_SHORT).show() | ||
| } | ||
| } else { | ||
| Toast.makeText(this, NOT_YET_REGISTERED_MSG, Toast.LENGTH_SHORT).show() |
There was a problem hiding this comment.
스낵바나 토스트를 발생시키는 함수는 프로젝트 전역에서 재사용될 수 있기 때문에 Activity나 Context, View의 확장함수를 사용하는 방법을 찾아보셔도 좋을 것 같습니다 :)
확장 함수 한번 만들어놓으면 코드량을 엄청 줄일 수 있기 때문에 굉장히 편리합니다!
Comment on lines
85
to
87
| val intent = Intent(this, MainActivity::class.java) | ||
| intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK or Intent.FLAG_ACTIVITY_NEW_TASK) | ||
| startActivity(intent) |
There was a problem hiding this comment.
Suggested change
| val intent = Intent(this, MainActivity::class.java) | |
| intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK or Intent.FLAG_ACTIVITY_NEW_TASK) | |
| startActivity(intent) | |
| Intent(this, MainActivity::class.java).apply { | |
| addFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK or Intent.FLAG_ACTIVITY_NEW_TASK) | |
| startActivity(this) | |
| } |
스코프 함수 apply나 also를 활용하여 코틀린스럽게 작성할 수도 있습니다 ㅎㅎ
Comment on lines
20
to
21
| binding.tvName.text = "이름: $name" | ||
| binding.tvHobby.text = "특기: $hobby" |
There was a problem hiding this comment.
Suggested change
| binding.tvName.text = "이름: $name" | |
| binding.tvHobby.text = "특기: $hobby" | |
| binding.tvName.append(name) | |
| binding.tvHobby.append(hobby) |
append() 함수를 활용하여 좀 더 간결하게 작성할 수도 있습니다!
Comment on lines
85
to
91
| private fun getAllInputValues(): List<String> { | ||
| val id = binding.etId.text.toString() | ||
| val pw = binding.etPw.text.toString() | ||
| val name = binding.etName.text.toString() | ||
| val hobby = binding.etHobby.text.toString() | ||
| return listOf(id, pw, name, hobby) | ||
| } |
There was a problem hiding this comment.
Suggested change
| private fun getAllInputValues(): List<String> { | |
| val id = binding.etId.text.toString() | |
| val pw = binding.etPw.text.toString() | |
| val name = binding.etName.text.toString() | |
| val hobby = binding.etHobby.text.toString() | |
| return listOf(id, pw, name, hobby) | |
| } | |
| private fun getAllInputValues(): User { | |
| val id = binding.etId.text.toString() | |
| val pw = binding.etPw.text.toString() | |
| val name = binding.etName.text.toString() | |
| val hobby = binding.etHobby.text.toString() | |
| return User(id, pw, name, hobby) | |
| } |
Data Class로 정의하신 User 클래스를 활용해보는 건 어떨까요?
Comment on lines
+93
to
+106
| private fun checkLengthOfId(id: String): Boolean { | ||
| return id.length in ID_MIN_LEN..ID_MAX_LEN | ||
| } | ||
|
|
||
| private fun checkLengthOfPw(pw: String): Boolean { | ||
| return pw.length in PW_MIN_LEN..PW_MAX_LEN | ||
| } | ||
|
|
||
| companion object { | ||
| private const val ID_MIN_LEN = 6 | ||
| private const val ID_MAX_LEN = 10 | ||
| private const val PW_MIN_LEN = 8 | ||
| private const val PW_MAX_LEN = 12 | ||
| } |
Comment on lines
3
to
7
| const val SIGN_UP_SUCCESS_MSG = "회원가입이 완료되었습니다." | ||
| const val LOGIN_SUCCESS_MSG = "로그인에 성공했습니다." | ||
| const val LOGIN_FAIL_MSG = "등록된 유저 정보가 없습니다." | ||
| const val NOT_YET_REGISTERED_MSG = "회원가입을 먼저 진행해주세요." | ||
| const val INVALID_INPUT_ERROR = "모든 항목에 유효한 값을 입력해주세요." |
There was a problem hiding this comment.
UI에 표시되는 메시지 문자열들은 strings.xml에서 정의하여 사용하는 것이 리소스 사용량을 줄이고 유지보수가 용이할 것 같습니다!
앱을 국제화하기 위해 다른 언어로 번역하여 지원하게 될 경우에도 편리할 것입니다 :)
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="20dp" | ||
| android:text="Welcome to GO Android!" |
There was a problem hiding this comment.
귀찮긴 하지만 xml에서도 텍스트 추출로 보일러플레이트를 줄여봅시다!
| android:text="Hello World!" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| tools:text="이름: " |
There was a problem hiding this comment.
위에서 설명드린 append 함수를 활용하게 된다면 android:text 속성을 활용하시면 될 것 같습니다!
Comment on lines
8
to
+10
| <color name="black">#FF000000</color> | ||
| <color name="white">#FFFFFFFF</color> | ||
| <color name="red">#F44336</color> |
There was a problem hiding this comment.
color까지 지정하시다니 👍👍
3주차 세미나 때 팟짱님이 알려주시겠지만 네이밍을 하실 때 Material Design을 참고하셔도 좋을 것 같아요 😉
sxunea
reviewed
Apr 7, 2023
| override fun beforeTextChanged(s: CharSequence?, start: Int, count: Int, after: Int) { | ||
| } | ||
|
|
||
| override fun onTextChanged(s: CharSequence?, start: Int, before: Int, count: Int) { |
There was a problem hiding this comment.
addTextChangedListener를 활용해 길이제한조건을 사용자에게 명시해주는 점 좋았습니다 😘
| return id.length in 6..10 | ||
| } | ||
|
|
||
| private fun checkValidityOfPw(pw: String): Boolean { | ||
| private fun checkLengthOfPw(pw: String): Boolean { |
There was a problem hiding this comment.
함수명이 항상 기능을 직관적으로 잘명시되어있는 것 같습니다 ! 참고해야겠어용
lsakee
reviewed
Apr 9, 2023
| binding.btnLogin.setOnClickListener { | ||
| if (userRegisteredStatus) { | ||
| if (checkInputValues()) { | ||
| Toast.makeText(this, LOGIN_SUCCESS_MSG, Toast.LENGTH_SHORT).show() |
| return id != null && pw != null && name != null && hobby != null | ||
| } | ||
|
|
||
| private fun hideKeyboard() { |
Comment on lines
+27
to
+38
| binding.etId.addTextChangedListener { | ||
| if (!checkLengthOfId(it.toString())) { | ||
| binding.tvIdLimitError.visibility = View.VISIBLE | ||
| } else { | ||
| binding.tvIdLimitError.visibility = View.INVISIBLE | ||
| } | ||
| } | ||
|
|
||
| binding.etPw.addTextChangedListener { | ||
| if (!checkLengthOfPw(it.toString())) { | ||
| binding.tvPwLimitError.visibility = View.VISIBLE | ||
| } else { |
26 tasks
leeeha
added a commit
that referenced
this pull request
Apr 21, 2023
leeeha
added a commit
that referenced
this pull request
Apr 21, 2023
leeeha
added a commit
that referenced
this pull request
Apr 21, 2023
leeeha
added a commit
that referenced
this pull request
Apr 21, 2023
leeeha
added a commit
that referenced
this pull request
Apr 21, 2023
leeeha
added a commit
that referenced
this pull request
Apr 21, 2023
leeeha
added a commit
that referenced
this pull request
Apr 21, 2023
leeeha
added a commit
that referenced
this pull request
Apr 21, 2023
leeeha
added a commit
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
필수 과제
심화 과제
도전 과제
실행 결과